[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1308967114.3093.1379.camel@localhost>
Date: Sat, 25 Jun 2011 02:58:34 +0100
From: Ben Hutchings <bhutchings@...arflare.com>
To: Matt Evans <matt@...abs.org>
Cc: netdev@...r.kernel.org,
linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [RFC PATCH 1/1] BPF JIT for PPC64
On Fri, 2011-06-24 at 16:02 +1000, Matt Evans wrote:
[...]
> + case BPF_S_ALU_ADD_K: /* A += K; */
> + if (!K)
> + break;
> + if (K < 32768)
> + PPC_ADDI(r_A, r_A, K);
> + else
> + PPC_ADDI(r_A, r_A, IMM_L(K));
> + PPC_ADDIS(r_A, r_A, IMM_HA(K));
> + break;
Missing braces.
> + case BPF_S_ALU_SUB_X: /* A -= X; */
> + ctx->seen |= SEEN_XREG;
> + PPC_SUB(r_A, r_A, r_X);
> + break;
> + case BPF_S_ALU_SUB_K: /* A -= K */
> + if (!K)
> + break;
> + if (K < 32768)
> + PPC_ADDI(r_A, r_A, -K);
> + else
> + PPC_ADDI(r_A, r_A, IMM_L(-K));
> + PPC_ADDIS(r_A, r_A, IMM_HA(-K));
> + break;
[...]
Here as well.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists