lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Jun 2011 15:53:53 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: jhs@...atatu.com Cc: David Miller <davem@...emloft.net>, Eric Dumazet <eric.dumazet@...il.com>, Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org Subject: Re: [PATCH] net_sched: fix dequeuer fairness On Sun, 2011-06-26 at 10:17 -0400, jamal wrote: [...] > diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c > index b4c6809..578269e 100644 > --- a/net/sched/sch_generic.c > +++ b/net/sched/sch_generic.c > @@ -190,14 +190,18 @@ static inline int qdisc_restart(struct Qdisc *q) > void __qdisc_run(struct Qdisc *q) > { > unsigned long start_time = jiffies; > + int quota = 0; > + int work = weight_p; These variable names seem to be the wrong way round, i.e. the weight is our 'quota' and the number of packets dequeued is the 'work' we've done. Ben. > while (qdisc_restart(q)) { > + quota++; > /* > - * Postpone processing if > - * 1. another process needs the CPU; > - * 2. we've been doing it for too long. > + * Ordered by possible occurrence: Postpone processing if > + * 1. we've exceeded packet quota > + * 2. another process needs the CPU; > + * 3. we've been doing it for too long. > */ > - if (need_resched() || jiffies != start_time) { > + if (quota >= work || need_resched() || jiffies != start_time) { > __netif_schedule(q); > break; > } > -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists