netdev - Re: [PATCH] net_sched: fix dequeuer fairness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1309104826.5134.46.camel@mojatatu>
Date:	Sun, 26 Jun 2011 12:13:46 -0400
From:	jamal <hadi@...erus.ca>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net_sched: fix dequeuer fairness

On Sun, 2011-06-26 at 17:53 +0200, Eric Dumazet wrote:

> 
> This is because of commit 24f8b2385e03a4f.
> 
> Prior to this, we could exit very fast from this function, even after
> receiving a single packet.
> 
> jiffies break is kind of lazy, IMHO ;)

And subjective to the value of Hz. 

In the case of net_rx_action it seems that we need
"something" other than packet budget to get us out of there
in extreme case when we loop and none of the netdevs have anything
to offer. 
In the other extreme it would be very unfair to yield because
of jiffies when budget is not exhausted and devices have something
to offer.

One approach could be to deduct their napi weight when they
return a 0 for work done.

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html