netdev - Re: [PATCH] [net][bna] Fix call trace when interrupts are disabled while sleeping function kzalloc is called

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110627.160706.1453191829412045606.davem@davemloft.net>
Date:	Mon, 27 Jun 2011 16:07:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shyam.iyer.t@...il.com
Cc:	netdev@...r.kernel.org, rmody@...cade.com, ddutt@...cadel.com,
	shyam_iyer@...l.com
Subject: Re: [PATCH] [net][bna] Fix call trace when interrupts are disabled
 while sleeping function kzalloc is called

From: Shyam Iyer <shyam.iyer.t@...il.com>
Date: Mon, 27 Jun 2011 16:21:32 -0400

> The kzalloc sleeps and disabling interrupts(spin_lock_irqsave)
> causes oops like the one.

What if ->cfg_flags changes while you have dropped the lock?

If the lock doesn't protect those flags, what was it being
taken for in the first place?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html