netdev - Re: [Socketcan-users] [PATCH] net/can: activate bit-timing calculation and netlink based drivers by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E083930.50102@grandegger.com>
Date:	Mon, 27 Jun 2011 10:02:56 +0200
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
CC:	davem@...emloft.net, netdev@...r.kernel.org,
	socketcan-users@...ts.berlios.de
Subject: Re: [Socketcan-users] [PATCH] net/can: activate bit-timing calculation
 and netlink based drivers by default

Hi Marc,

On 06/27/2011 09:39 AM, Marc Kleine-Budde wrote:
> The two options "CAN bit-timing calculation" and
> "Platform CAN drivers with Netlink support" have a "default Y". In order to
> activate them by default, change to "default y".
> 
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> ---
>  drivers/net/can/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> index bbf06f7..f1f9fd9 100644
> --- a/drivers/net/can/Kconfig
> +++ b/drivers/net/can/Kconfig
> @@ -36,7 +36,7 @@ config CAN_SLCAN
>  config CAN_DEV
>  	tristate "Platform CAN drivers with Netlink support"
>  	depends on CAN
> -	default Y
> +	default y
>  	---help---
>  	  Enables the common framework for platform CAN drivers with Netlink
>  	  support. This is the standard library for CAN drivers.
> @@ -45,7 +45,7 @@ config CAN_DEV
>  config CAN_CALC_BITTIMING
>  	bool "CAN bit-timing calculation"
>  	depends on CAN_DEV
> -	default Y
> +	default y
>  	---help---
>  	  If enabled, CAN bit-timing parameters will be calculated for the
>  	  bit-rate specified via Netlink argument "bitrate" when the device

Acked-by: Wolfgang Grandegger <wg@...ndegger.com>

Ahh, ohh, a trivial fix for a long-standing problem. Would be nice if
Kbuild would report such invalid default settings.

Thanks,

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html