netdev - Re: [PATCH 15/19 v2] tg3: remove unnecessary read of PCI_CAP_ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110627.213932.828761097349347608.davem@davemloft.net>
Date:	Mon, 27 Jun 2011 21:39:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mcarlson@...adcom.com, jdmason@...zu.us
Cc:	mchan@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH 15/19 v2] tg3: remove unnecessary read of PCI_CAP_ID_EXP

From: "Matt Carlson" <mcarlson@...adcom.com>, "Jon Mason" <jdmason@...zu.us>
Date: Mon, 27 Jun 2011 16:33:52 -0700

> On Mon, Jun 27, 2011 at 03:56:50PM -0700, Jon Mason wrote:
>> The PCIE capability offset is saved during PCI bus walking.  Use the
>> value from pci_dev instead of checking in the driver and saving it off
>> the the driver specific structure.  It will remove an unnecessary search
>> in the PCI configuration space if this value is referenced instead of
>> reacquiring it.
>> 
>> v2 of the patch re-adds the PCI_EXPRESS flag and adds comments
>> describing why it is necessary.
>> 
>> Signed-off-by: Jon Mason <jdmason@...zu.us>
...
> Sorry to be a stickler, but can we convert all occurances of
> 'tp->pdev->pcie_cap' to pci_pcie_cap(tp->pdev)?  If the PCI layer is
> taking control of that variable, the driver shouldn't be accessing it
> directly if it can help it.

I did this while adding this patch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html