[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1309372139.2714.6.camel@bwh-desktop>
Date: Wed, 29 Jun 2011 19:28:59 +0100
From: Ben Hutchings <bhutchings@...arflare.com>
To: amit.salecha@...gic.com
Cc: davem@...emloft.net, netdev@...r.kernel.org,
ameen.rahman@...gic.com
Subject: Re: [PATCH NEXT 1/2] net: add external loopback test in ethtool
self test
On Mon, 2011-06-27 at 23:40 -0700, amit.salecha@...gic.com wrote:
> From: Amit Kumar Salecha <amit.salecha@...gic.com>
>
> External loopback test can be performed by application without any driver
> support on normal Ethernet cards.
> But on CNA devices, where multiple functions share same physical port.
> Here internal loopback test and external loopback test can be initiated by
> different function at same time. To co exist all functions, firmware need
> to regulate what test can be run by which function. So before performing external
> loopback test, command need to send to firmware, which will quiescent other functions.
>
> User may not want to run external loopback test always. As special cable need to be
> connected for this test.
>
> So adding explicit flag in ethtool self test, which will specify interface
> to perform external loopback test.
The trouble with adding flags to enum ethtool_test_flags is that there
is really no general way to tell whether the driver understood the flag.
I think you need to add a second flag which the driver sets to confirm
that it *did* use external loopback.
> Signed-off-by: Amit Kumar Salecha <amit.salecha@...gic.com>
> ---
> include/linux/ethtool.h | 13 +++++++++++--
> 1 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index 048d0fa..c2ba287 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -310,9 +310,18 @@ struct ethtool_sset_info {
> __u32's, etc. */
> };
>
> +/*
> + * Flags definition of ethtool_test
> + *
> + * ETH_TEST_FL_OFFLINE: online / offline
> + * ETH_TEST_FL_FAILED: test passed / failed
> + * ETH_TEST_FL_EXTERNAL_LB: perform external loopback test
> + */
> +
Replacing the inline comments with a block comment is fine, but please
use kernel-doc format.
Ben.
> enum ethtool_test_flags {
> - ETH_TEST_FL_OFFLINE = (1 << 0), /* online / offline */
> - ETH_TEST_FL_FAILED = (1 << 1), /* test passed / failed */
> + ETH_TEST_FL_OFFLINE = (1 << 0),
> + ETH_TEST_FL_FAILED = (1 << 1),
> + ETH_TEST_FL_EXTERNAL_LB = (1 << 2),
> };
>
> /* for requesting NIC test and getting results*/
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists