netdev - Re: [PATCH] net/core: Convert to current logging forms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1309453837.7277.3.camel@Joe-Laptop>
Date:	Thu, 30 Jun 2011 10:10:37 -0700
From:	Joe Perches <joe@...ches.com>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/core: Convert to current logging forms

On Thu, 2011-06-30 at 09:55 +0000, WANG Cong wrote:
> On Tue, 28 Jun 2011 12:40:10 -0700, Joe Perches wrote:
> > Use pr_fmt, pr_<level>, and netdev_<level> as appropriate.
> > Coalesce long formats.
> > +		np->name, np->local_port);
> > +	pr_info("%s: local IP %pI4\n",
> > +		np->name, &np->local_ip);
> > +	pr_info("%s: interface '%s'\n",
> > +		np->name, np->dev_name);
> > +	pr_info("%s: remote port %d\n",
> > +		np->name, np->remote_port);
> > +	pr_info("%s: remote IP %pI4\n",
> > +		np->name, &np->remote_ip);
> > +	pr_info("%s: remote ethernet address %pM\n",
> > +		np->name, np->remote_mac);
> >  }
> This doesn't have much value, because the name of the netpoll
> user (np->name) is already logged. If we changed it,
> we would see "netconsole: netconsole: blah blah...".

Thanks.

Don't just reply to the lists.
Remember to include the patch author in your replies.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html