netdev - Re: [PATCH net-next] net: de4x5: Omit check for multicast bit in netdev_for_each_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110630.235730.726339338074212677.davem@davemloft.net>
Date:	Thu, 30 Jun 2011 23:57:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tklauser@...tanz.ch
Cc:	grundler@...isc-linux.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: de4x5: Omit check for multicast bit in
 netdev_for_each_mc_addr

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Wed, 29 Jun 2011 14:16:00 +0200

> There is no need to check for the address being a multicast address in
> the netdev_for_each_mc_addr loop, so remove it.
> 
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Please build test your patches!

> @@ -1954,7 +1954,6 @@ SetMulticastFilter(struct net_device *dev)
>      u16 hashcode;
>      u32 omr, crc;
>      char *pa;
> -    unsigned char *addrs;
>  
>      omr = inl(DE4X5_OMR);
>      omr &= ~(OMR_PR | OMR_PM);

You removed this local variable 'addrs' but you did not remove
all uses of that variable, so the build will fail.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html