netdev - Re: [PATCH net-next] net: de4x5: Omit check for multicast bit in netdev_for_each_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110701.003104.1560405560789304913.davem@davemloft.net>
Date:	Fri, 01 Jul 2011 00:31:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tklauser@...tanz.ch
Cc:	grundler@...isc-linux.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: de4x5: Omit check for multicast bit in
 netdev_for_each_mc_addr

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Fri, 1 Jul 2011 09:25:33 +0200

> On 2011-07-01 at 08:57:30 +0200, David Miller <davem@...emloft.net> wrote:
>> From: Tobias Klauser <tklauser@...tanz.ch>
>> Date: Wed, 29 Jun 2011 14:16:00 +0200
>> 
>> > There is no need to check for the address being a multicast address in
>> > the netdev_for_each_mc_addr loop, so remove it.
>> > 
>> > Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
>> 
>> Please build test your patches!
> 
> Sorry for the mess. Here's an updated patch, not removing the addrs
> local variable.
> 
> There is no need to check for the address being a multicast address in
> the netdev_for_each_mc_addr loop, so remove it.
> 
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Do not mix patch submissions into existing discussions.

Please, instead, make a new fresh patch submission.

Otherwise I have to do a lot of work editing your commit
log messages and the headers.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html