netdev - coding style question on indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Jul 2011 04:20:30 -0700
From:	<Sathya.Perla@...lex.Com>
To:	<netdev@...r.kernel.org>
Subject: coding style question on indentation

Hi,
Which of the following styling is preferable when a function invocation spans more than one line:

a) Aligning the next line with the first argument by inserting a few spaces after the tabs - as in:

	dma_unmap_page(&adapter->pdev->dev,
			   dma_unmap_addr(rx_page_info, bus),
			   adapter->big_page_size, DMA_FROM_DEVICE);

Documentation/CodingStyle says "spaces are never used for indentation", but I see
scripts/Lindent inserting spaces after tabs for alignment.

OR

b) Just using tabs without needing to align as above:

	dma_unmap_page(&adapter->pdev->dev,
			dma_unmap_addr(rx_page_info, bus),
			adapter->big_page_size, DMA_FROM_DEVICE);


thanks,
-Sathya
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html