netdev - Re: [PATCH] gianfar: code cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 01 Jul 2011 17:46:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sebastian.belden@...glemail.com
Cc:	netdev@...r.kernel.org, joe@...ches.com, sebastian.poehn@...den.com
Subject: Re: [PATCH] gianfar: code cleanups

From: "Sebastian Pöhn" <sebastian.belden@...glemail.com>
Date: Fri, 01 Jul 2011 11:00:43 +0200

> # moves if_vlan.h include from gianfar.c to gianfar.h

Please don't do this, keep the explicit includes as close
to the actual dependencies as possible.  With your change
all of the other source files will load in and parse if_vlan.h
even though they have no need for it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html