netdev - Re: [PATCH 1/2] netpoll: Remove unused EXPORT_SYMBOLs of netpoll_poll and netpoll_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110704092736.GA2932@gmail.com>
Date:	Mon, 4 Jul 2011 17:27:38 +0800
From:	Harry Wei <jiaweiwei.xiyou@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	amwang@...hat.com, linux-kernel@...r.kernel.org,
	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] netpoll: Remove unused EXPORT_SYMBOLs of
 netpoll_poll and netpoll_poll_dev

On Mon, Jul 04, 2011 at 12:46:29AM -0700, Joe Perches wrote:
[...]
> > You have removed the function declaration in include/linux/netpoll.h.
> 
> Because it's unused by anything in the tree
> but netpoll.c
Hmmmm..., so sorry. I misunderstood your 'unused', which i thought
there was also no use in netpoll.c :-/
> 
> > And you changed the function like 
> > static void netpoll_poll_dev(...)
> > {
> > 	...
> > }
> > But i don't know its usage.
> 
> It's now a local function to netpoll.c
Yeah, it's true.
> 
> > The 'static' before this function just says the active area of 'netpoll_poll_dev'
> > is in the file net/core/netpoll.c. What is the purpose? Could you please tell me?
> 
> It prods the device to perform network work.
> 
> 	/* Process pending work on NIC */
> 	ops->ndo_poll_controller(dev);
> 
> 	poll_napi(dev);
Yeah, i will read the codes.


Thanks so much
Harry Wei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html