netdev - Re: [net-next PATCH 1/2] dcbnl: Aggregated CEE GET operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1309803754.9038.9.camel@lb-tlvb-shmulik.il.broadcom.com>
Date:	Mon, 4 Jul 2011 21:22:34 +0300
From:	"Shmulik Ravid" <shmulikr@...adcom.com>
To:	"John Fastabend" <john.r.fastabend@...el.com>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net-next PATCH 1/2] dcbnl: Aggregated CEE GET operation


On Sun, 2011-07-03 at 11:09 -0700, John Fastabend wrote:
> >  
> > +static int dcbnl_cee_pg_fill(struct sk_buff *skb, struct net_device *dev,
> > +			     int dir)
> 
> Why the 'dir'? Could you just pack both tx and rx together? It looks like all
> cases pack TX then pack RX. Did I miss something?
> 
This is just an auxiliary function meant to avoid duplicating the loops
that build the DCB_ATTR_CEE_TX_PG and DCB_ATTR_CEE_RX_PG nested
attributes. The only differences are the parent attribute and the driver
callbacks. Its similar to the way  dcbnl_pgtx_getcfg() and
dcbnl_pgrx_getcfg() are already implemented.

I'll incorporate the other comments to a v2 version of the patch.

Thanks,
Shmulik



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html