netdev - Re: [PATCH 2/2] packet: Add fanout support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1309859424.2271.5.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Tue, 05 Jul 2011 11:50:24 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	victor@...iniac.net, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] packet: Add fanout support.

Le mardi 05 juillet 2011 à 00:46 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Tue, 05 Jul 2011 08:21:15 +0200
> 
> > rxhash is 0 unless skb_get_rxhash() was called, or some NIC set it in RX
> > path.
> 
> CONFIG_RPS is effectively on all the time for SMP builds.
> 
> If you want to make it a hard enable in that situation,
> I fully support such a change. :-)
> 

CONFIG_RPS can be on, but skb->rxhash still 0 by default on tg3 for
example.

get_rps_cpu() wont call skb_get_rxhash() if RPS/RFS is not setup on
rxqueue (rps_map == NULL and rps_flow_table = NULL)

You really have to call skb_get_rxhash() yourself to make sure rxhash is
set (if not already done)

Just replace   skb->rxhash by skb_get_rxhash(skb)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html