netdev - Re: [Bugme-new] [Bug 38862] New: No support for DGE-530T Rev C1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2011 14:54:07 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	James Henderson <JamesHenderson@...gedcom.com>
Cc:	"bugme-daemon@...zilla.kernel.org" <bugme-daemon@...zilla.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Stephen Hemminger <shemminger@...ux-foundation.org>
Subject: Re: [Bugme-new] [Bug 38862] New: No support for DGE-530T Rev C1

On Wed, 6 Jul 2011 17:48:44 -0400
James Henderson <JamesHenderson@...gedcom.com> wrote:

> > Did you test simply adding that device to the driver?
> >
> > --- a/drivers/net/skge.c~a
> > +++ a/drivers/net/skge.c
> > @@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T */
> > +	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) },	/* DGE-530T Rev C1 */
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },
> > _
> >
> >   
> No I haven't tested that change - I don't have a kernel development 
> environment setup and unfortunately I don't have any more work time to 
> budget to the issue beyond reporting it.
> 
> Also, I meant to say that Rev B2 has PCI id 1186:4B01 (although you seem 
> to have figured that out).

OK, I suppose we can add that info thusly:

--- a/drivers/net/skge.c~drivers-net-skgec-support-dlink-dge-530t-rev-c1
+++ a/drivers/net/skge.c
@@ -88,7 +88,8 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_GE) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T */
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T Rev B2 */
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) },	/* DGE-530T Rev C1 */
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
 	{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },
_

although that might be misleading if, say, 0x4b01 describes other
revisions.

But there isn't much we can do with this until someone can test the
change.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html