netdev - Re: [PATCH v2] net: sched: constify tcf_proto and tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110705.225921.2065481038863776818.davem@davemloft.net>
Date:	Tue, 05 Jul 2011 22:59:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: sched: constify tcf_proto and tc_action

From: David Miller <davem@...emloft.net>
Date: Tue, 05 Jul 2011 22:56:33 -0700 (PDT)

> From: David Miller <davem@...emloft.net>
> Date: Tue, 05 Jul 2011 22:36:35 -0700 (PDT)
> 
>> From: Eric Dumazet <eric.dumazet@...il.com>
>> Date: Wed, 06 Jul 2011 06:32:45 +0200
>> 
>>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
>> 
>> Applied.
> 
> net/sched/cls_cgroup.c:279:2: warning: initialization from incompatible pointer type [enabled by default]
> net/sched/cls_cgroup.c:279:2: warning: (near initialization for ‘cls_cgroup_ops.classify’) [enabled by default]

BTW, is is really so hard for people to do "allmodconfig"
builds?

You can take your chances the first time, but if you need to respin
because of warnings and breakage, the onus is on you to actually do a
real complete build regression test on your changes.

I shouldn't be the one hitting this stuff, you folks should.