netdev - Re: [PATCH] ATM: Fix wrong usage of INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110707.045159.735589070219101177.davem@davemloft.net>
Date:	Thu, 07 Jul 2011 04:51:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	stufever@...il.com
Cc:	netdev@...r.kernel.org, wangshaoyan.pt@...bao.com,
	chas@....nrl.navy.mil, linux-atm-general@...ts.sourceforge.net
Subject: Re: [PATCH] ATM: Fix wrong usage of INIT_WORK

From: stufever@...il.com
Date: Thu,  7 Jul 2011 19:51:52 +0800

> From: Wang Shaoyan <wangshaoyan.pt@...bao.com>
> 
> If we define FILL_RX_POOLS_IN_BH, the compiler will report error such as
>   drivers/atm/ambassador.c:2159:64: error: macro "INIT_WORK" passed 3 arguments, but takes just 2
> because the function INIT_WORK() don't accept "data" now, it only has
> two arguments, so use the right way to initialise work queue.
> 
> Cc: Chas Williams <chas@....nrl.navy.mil> (maintainer:ATM)
> Cc: linux-atm-general@...ts.sourceforge.net (open list:ATM)
> Signed-off-by: Wang Shaoyan <wangshaoyan.pt@...bao.com>

This just makes the driver a bigger CPP mess.

Unconditionally provide the dev->bh member, and unconditionally pass
it into the worker function.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html