netdev - Re: [RFC 46/72] ixp2000: Move the Radisys driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1310227137.26989.43.camel@jtkirshe-mobl>
Date:	Sat, 09 Jul 2011 08:58:56 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Lennert Buytenhek <kernel@...tstofly.org>
Subject: Re: [RFC 46/72] ixp2000: Move the Radisys driver

On Sun, 2011-06-26 at 04:47 -0700, Lennert Buytenhek wrote:
> On Sat, Jun 25, 2011 at 06:58:57AM -0700, Jeff Kirsher wrote:
> 
> > Move the Radisys driver into drivers/net/ethernet/radisys/ and
> > make the necessary Kconfig and Makefile changes
> > 
> > CC: Lennert Buytenhek <kernel@...tstofly.org>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > ---
> >  MAINTAINERS                                        |    2 +-
> >  drivers/net/Kconfig                                |    2 --
> >  drivers/net/Makefile                               |    1 -
> >  drivers/net/ethernet/Kconfig                       |    1 +
> >  drivers/net/ethernet/Makefile                      |    1 +
> >  drivers/net/ethernet/radisys/Kconfig               |   16 ++++++++++++++++
> >  drivers/net/ethernet/radisys/Makefile              |    5 +++++
> >  drivers/net/{ => ethernet/radisys}/ixp2000/Kconfig |    2 +-
> >  .../net/{ => ethernet/radisys}/ixp2000/Makefile    |    0
> 
> The ixp2000 is a series of Intel ARM SoCs, and the ENP2611 is a Radisys
> PCI board based on the ixp2000 series (ixp2400), so it doesn't make
> sense to put everything in the radisys/ directory.

It was suggested earlier that it probably should be in either ixp/ or
radisys/, and someone suggested that ixp/ might be confusing.  If you
would like to keep it under drivers/net/ethernet/ixp2000, I am fine with
that as well.

> 
> If you insist on moving all drivers into vendor directories (I don't
> like that idea at all -- are we going to rename directories and shuffle
> stuff around every time vendor A buys vendor B or takes over one of
> vendor B's products?), at least the core ixp2000 code should be under
> intel/.

It was not my preference to place drivers into vendor specific
directories because of that very reason, as I did the work, it just
tended to work out that way.

The reason (as stated before) that it was not moved into intel/
directory is because the driver was not written (and supported) by
Intel.

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)