netdev - Re: [PATCH 00/21] clean up rx_copybreak handling [split version]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110710115206.GA24395@rere.qmqm.pl>
Date:	Sun, 10 Jul 2011 13:52:06 +0200
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org,
	Steffen Klassert <klassert@...hematik.tu-chemnitz.de>,
	Santiago Leon <santil@...ux.vnet.ibm.com>,
	Tim Hockin <thockin@...kin.org>,
	Don Fry <pcnet32@...ntier.com>,
	Francois Romieu <romieu@...zoreil.com>,
	Ion Badulescu <ionut@...ula.org>,
	Matt Carlson <mcarlson@...adcom.com>,
	Michael Chan <mchan@...adcom.com>,
	Grant Grundler <grundler@...isc-linux.org>,
	David Dillow <dave@...dillows.org>,
	Roger Luethi <rl@...lgate.ch>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 00/21] clean up rx_copybreak handling [split version]

On Sun, Jul 10, 2011 at 01:28:18PM +0200, Michał Mirosław wrote:
> On Sat, Jul 09, 2011 at 11:20:32AM -0700, Joe Perches wrote:
> > On Sat, 2011-07-09 at 19:17 +0200, Michał Mirosław wrote:
> > > Split version of rx_copybreak cleanup patch.
> > 
> > Hello Michał.
> > 
> > Looks good, thanks for doing this work.
> > 
> > One style quibble.
> > 
> > You use this style:
> > 
> > +			skb = dev_skb_finish_rx_dma(&np->rx_skbuff[entry],
> > +				pkt_len, rx_copybreak,
> > +				&np->pci_dev->dev,
> > +				le32_to_cpu(desc->frag[0].addr),
> > +				np->rx_buf_sz);
> > 
> > where almost all other uses throughout drivers/net
> > align arguments to open parenthesis instead.
> > 
> > +			skb = dev_skb_finish_rx_dma(&np->rx_skbuff[entry],
> > +						    pkt_len, rx_copybreak,
> > +						    &np->pci_dev->dev,
> > +						    le32_to_cpu(desc->frag[0].addr),
> > +						    np->rx_buf_sz);
> 
> I'll fix that in v2 where the style differs.

I modified patches where surrounding code had been consistent. I'm now
convinced I don't like this style, especially when combined with 80-column
limit and no limit on indentation levels.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html