netdev - Re: [PATCH] natsemi: silence dma-debug warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110710.105730.1305564732068163754.fujita.tomonori@lab.ntt.co.jp>
Date:	Sun, 10 Jul 2011 10:57:30 +0900 (JST)
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	jim.cromie@...il.com
Cc:	davem@...emloft.net, thockin@...kin.org, netdev@...r.kernel.org
Subject: Re: [PATCH] natsemi: silence dma-debug warnings

On Sat, 9 Jul 2011 19:45:22 -0600
Jim Cromie <jim.cromie@...il.com> wrote:

> On Sat, Jul 9, 2011 at 7:20 PM, FUJITA Tomonori
> <fujita.tomonori@....ntt.co.jp> wrote:
>> On Sat, 9 Jul 2011 14:11:25 -0600
>> Jim Cromie <jim.cromie@...il.com> wrote:
>>
>>> On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@...emloft.net> wrote:
>>>> From: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
>>>> Date: Mon, 4 Jul 2011 14:30:19 +0900
>>>>
>>>>> This silences dma-debug warnings:
>>>>>
>>>>> https://lkml.org/lkml/2011/6/30/341
>>>>  ...
>>>>> Reported-by: Jim Cromie <jim.cromie@...il.com>
>>>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
>>>>> Tested-by: Jim Cromie <jim.cromie@...il.com>
>>>>
>>>> Applied, thanks!
>>>>
>>>
>>> I have since seen a similar warning on shutdown,
>>> heres a patch for it.
>>
>> Oops, I noticed this too but I forgot to send a patch.
>>
>> The patch looks good to me.
>>
>>
>>> theres one other callsite, but I havent seen the warning from it,
>>> will try to tickle it at some point.
>>
>> Which pci_unmap_single are you talking about?
>>
> 
> 
>    2131 static void netdev_tx_done(struct net_device *dev)
>    2132 {
> ...
>    2160                 pci_unmap_single(np->pci_dev,np->tx_dma[entry],
>    2161                                         np->tx_skbuff[entry]->len,
>    2162                                         PCI_DMA_TODEVICE);

It's pci_unmap_single call for tx_dma buffers. We fixed
pci_unmap_single calls for rx_dma buffers.

Looks like the driver correctlly uses pci_map_single and
pci_unmap_single for tx_dma buffers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html