netdev - Re: [PATCH] slip: fix wrong SLIP6 ifdef-endif placing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110710.113741.2147626275846755476.davem@davemloft.net>
Date:	Sun, 10 Jul 2011 11:37:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	matvejchikov@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] slip: fix wrong SLIP6 ifdef-endif placing

From: Matvejchikov Ilya <matvejchikov@...il.com>
Date: Sun, 10 Jul 2011 22:32:55 +0400

> SLIP6 have nothing to do with CSLIP so placing a block of
> SLIP6-related code within a CSLIP ifdef-endif block is incorrect.
> 
> Signed-off-by: Ilya Matvejchikov <matvejchikov@...il.com>
 ...
> @@ -194,8 +194,7 @@ static int sl_alloc_bufs(struct slip *sl, int mtu)
>  err_exit:
>  #ifdef SL_INCLUDE_CSLIP
>  	kfree(cbuff);
> -	if (slcomp)
> -		slhc_free(slcomp);
> +	slhc_free(slcomp);
>  #endif

The change in this hunk has nothing to do with what you
claim to be doing in your commit message.

Don't mix unrelated changes together.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html