netdev - Re: [PATCH] [PATCH] Fix deadlock in af_packet while stressing raw ethernet socket interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110711.202717.1764669415135298036.davem@davemloft.net>
Date:	Mon, 11 Jul 2011 20:27:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ronny.meeus@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] [PATCH] Fix deadlock in af_packet while stressing raw
 ethernet socket interface

From: Ronny Meeus <ronny.meeus@...il.com>
Date: Sat, 11 Jun 2011 07:04:09 +0200

> I was running a test: 1 application was sending raw Ethernet packets
> on a physical looped interface while a second application was
> receiving packets, so the latter application receives each packet 2
> times (once while sending from the context of the first application
> and a second time while receiving from the hardware).  After some
> time, the test blocks due to a spinlock reentrance issue in
> af_packet. Both the sending application and the softIRQ receiving
> packets enter the spinlock code. After applying the patch below, the
> issue is resolved.
>
> Signed-off-by: Ronny Meeus <ronny.meeus@...il.com>

The packet receive hooks should always be called with software
interrupts disabled, it is a bug if this is not happening.  Your
patch should not be necessary at all.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html