netdev - Re: [PATCH] [PATCH] Fix deadlock in af_packet while stressing raw ethernet socket interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1310458986.4763.4.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Tue, 12 Jul 2011 10:23:06 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	ronny.meeus@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] [PATCH] Fix deadlock in af_packet while stressing raw
 ethernet socket interface

Le mardi 12 juillet 2011 à 00:19 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Tue, 12 Jul 2011 08:58:48 +0200
> 
> > This seems a bug, but in softirq handling in your arch
> 
> That's not the problem, it's the dev_queue_xmit_nit() code
> path that interrupt is interrupting.

Isnt it what I said ?

Unless I am mistaken, dev_queue_xmit_nit() is called from
dev_hard_start_xmit(), and from dev_queue_xmit(), therefore BH
are/should_be masked. Calling do_softirq() while BH are masked is the
bug.

Something must be messing the !in_interrupt() test done from irq_exit()



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html