netdev - Re: netdevice: Kill 'feature' test macros.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110712120923.e90730f8.rdunlap@xenotime.net>
Date:	Tue, 12 Jul 2011 12:09:23 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Stephen Hemminger <shemminger@...tta.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: netdevice: Kill 'feature' test macros.

On Tue, 12 Jul 2011 21:06:21 +0200 Arnd Bergmann wrote:

> On Tuesday 12 July 2011 20:10:33 Stephen Hemminger wrote:
> > On Tue, 12 Jul 2011 10:50:05 -0700 (PDT)
> > David Miller <davem@...emloft.net> wrote:
> > 
> > > 
> > > Almost all of these have long outstayed their welcome.
> > > 
> > > And for every one of these macros, there are 10 features for which we
> > > didn't get macros added.
> > > 
> > > Let's just delete them all, and get out of habit of doing things this
> > > way.
> > > 
> > > Signed-off-by: David S. Miller <davem@...emloft.net>
> > 
> > Acked-by: Stephen Hemminger <shemminger@...tta.com>
> > 
> > This is sure to break out of tree drivers...
> 
> I guess that's a good thing, but it also breaks these:
> 
> drivers/staging/wlags49_h2/wl_internal.h:#ifdef HAVE_NETDEV_PRIV
> drivers/net/cxgb4vf/cxgb4vf_main.c:#ifdef HAVE_NET_DEVICE_OPS
> drivers/staging/ft1000/ft1000-usb/ft1000_hw.c:#ifdef HAVE_NET_DEVICE_OPS
> net/batman-adv/soft-interface.c:#ifdef HAVE_NET_DEVICE_OPS

Really?  I thought it would only break:

#if UNKNOWN_SYMBOL
but not
#ifdef UNKNOWN_SYMBOL


> Acked-by: Arnd Bergmann <arnd@...db.de>
> 
> if the above are taken care of.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html