netdev - Re: [PATCH] net/ps3: Fix gelic RX DMA restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110714.160340.670777033431904110.davem@davemloft.net>
Date:	Thu, 14 Jul 2011 16:03:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	geoff@...radead.org
Cc:	netdev@...r.kernel.org, cbe-oss-dev@...ts.ozlabs.org
Subject: Re: [PATCH] net/ps3: Fix gelic RX DMA restart

From: Geoff Levand <geoff@...radead.org>
Date: Thu, 14 Jul 2011 10:15:26 -0700

> Fix the condition where PS3 network RX hangs when no network
> TX is occurring by calling gelic_card_enable_rxdmac() during
> RX_DMA_CHAIN_END event processing.
> 
> The gelic hardware automatically clears its RX_DMA_EN flag when
> it detects an RX_DMA_CHAIN_END event.  In its processing of
> RX_DMA_CHAIN_END the gelic driver is required to set RX_DMA_EN
> (with a call to gelic_card_enable_rxdmac()) to restart RX DMA
> transfers.  The existing gelic driver code does not set
> RX_DMA_EN directly in its processing of the RX_DMA_CHAIN_END
> event, but uses a flag variable card->rx_dma_restart_required
> to schedule the setting of RX_DMA_EN until next inside the
> interrupt handler.
> 
> It seems this delayed setting of RX_DMA_EN causes the hang since
> the next RX interrupt after the RX_DMA_CHAIN_END event where
> RX_DMA_EN is scheduled to be set will not occur since RX_DMA_EN
> was not set.  In the case were network TX is occuring, RX_DMA_EN
> is set in the next TX interrupt and RX processing continues.
> 
> Signed-off-by: Geoff Levand <geoff@...radead.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html