netdev - gianfar vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20110714131426.GA11691@minipsycho.brq.redhat.com>
Date:	Thu, 14 Jul 2011 15:14:27 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	sandeep.kumar@...escale.com
Cc:	netdev@...r.kernel.org, sebastian.poehn@...den.com,
	davem@...emloft.net, B06378@...escale.com
Subject: gianfar vlan

Hi Sandeep.

I'm trying to remove gfar_vlan_rx_register() and move the vlan accel
enabling/disabling to gfar_set_features() -> startup_gfar() ->
gfar_init_mac(). I'm not sure how to handle following lines in
gfar_vlan_rx_register():

/* If parse is no longer required, then disable parser */
if (tempval & RCTRL_REQ_PARSER)
	tempval |= RCTRL_PRSDEP_INIT;
else
	tempval &= ~RCTRL_PRSDEP_INIT;

Should this be done only on disabling vlan accel (both rx an tx)?
Or can I just do that always in startup_gfar() ?

Thanks.

Jirka

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html