| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20110714.144314.1353889855984029341.davem@davemloft.net> Date: Thu, 14 Jul 2011 14:43:14 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mirq-linux@...e.qmqm.pl Cc: netdev@...r.kernel.org, fubar@...ibm.com, andy@...yhouse.net, kaber@...sh.net Subject: Re: [PATCH 06/10] net: remove NETIF_F_ALL_TX_OFFLOADS From: Michaİİ Mirosİİaw <mirq-linux@...e.qmqm.pl> Date: Thu, 14 Jul 2011 02:10:29 +0200 (CEST) > There is no software fallback implemented for SCTP or FCoE checksumming, > and so it should not be passed on by software devices like bridge or bonding. > > For VLAN devices, this is different. First, the driver for underlying device > should be prepared to get offloaded packets even when the feature is disabled > (especially if it advertises it in vlan_features). Second, devices under > VLANs do not get replaced without tearing down the VLAN first. > > This fixes a mess I accidentally introduced while converting bonding to > ndo_fix_features. > > NETIF_F_SOFT_FEATURES are removed from BOND_VLAN_FEATURES because they > are unused as of commit 712ae51afd. > > Signed-off-by: Michaİİ Mirosİİaw <mirq-linux@...e.qmqm.pl> This is not the answer. We have to implement software fallbacks for the checksum offloads. That is easier than having this ever growing set of exceptions for feature bit propagation, which at best will end up being a steaming pile of unmaintainable poo. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists