netdev - Re: gianfar vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110715091600.GA2250@minipsycho.brq.redhat.com>
Date:	Fri, 15 Jul 2011 11:16:02 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Sebastian Pöhn 
	<sebastian.belden@...glemail.com>
Cc:	sandeep.kumar@...escale.com, netdev@...r.kernel.org,
	Sebastian Pöhn <sebastian.poehn@...den.com>
Subject: Re: gianfar vlan

Fri, Jul 15, 2011 at 09:59:03AM CEST, sebastian.belden@...glemail.com wrote:
>Hi Jirka!
>
>The rx queue filer table also needs the RCTRL_PRSDEP_INIT to be set. So I would suggest to add FILREN to RCTRL_REQ_PARSER.
>
>Further I guess the parser should only be enabled if it is necessary (because of VLAN, IP, TCP or FILREN acceleration modes).
>
>What about putting the
>
>if (tempval & RCTRL_REQ_PARSER)
>	tempval |= RCTRL_PRSDEP_INIT;
>else
>	tempval &= ~RCTRL_PRSDEP_INIT;
>
>in a dedicated routine and call it every time one of the four features is altered?

Ok why not. Would you please cook up the patch and post it? Thanks.

Jirka

>
>Greetings
>Sebastian
>
>> Hi Sandeep.
>> 
>> I'm trying to remove gfar_vlan_rx_register() and move the vlan accel
>> enabling/disabling to gfar_set_features() -> startup_gfar() ->
>> gfar_init_mac(). I'm not sure how to handle following lines in
>> gfar_vlan_rx_register():
>> 
>> /* If parse is no longer required, then disable parser */
>> if (tempval & RCTRL_REQ_PARSER)
>> tempval |= RCTRL_PRSDEP_INIT;
>> else
>> tempval &= ~RCTRL_PRSDEP_INIT;
>> 
>> Should this be done only on disabling vlan accel (both rx an tx)?
>> Or can I just do that always in startup_gfar() ?
>> 
>> Thanks.
>> 
>> Jirka
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html