netdev - Re: [PATCH] gianfar: rx parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110715.080610.256697325487445331.davem@davemloft.net>
Date:	Fri, 15 Jul 2011 08:06:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sebastian.belden@...glemail.com
Cc:	netdev@...r.kernel.org, jpirko@...hat.com,
	sandeep.kumar@...escale.com
Subject: Re: [PATCH] gianfar: rx parser

From: "Sebastian Pöhn" <sebastian.belden@...glemail.com>
Date: Fri, 15 Jul 2011 13:09:01 +0200

> +	struct gfar __iomem *regs = NULL;
> +	u32 tempval = 0;
> +	
> +	regs = priv->gfargrp[0].regs;

There is no reason to initialize the variable 'regs' to NULL only to
initialize it to something else 2 lines later.

The initial 'tempval' initialization is also redundant, for the same
reason.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html