netdev - Re: [patch net-next-2.6 00/22] vlan cleanup round1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110716100548.GA2189@minipsycho.orion>
Date:	Sat, 16 Jul 2011 12:05:49 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Michał Mirosław <mirqus@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	shemminger@...ux-foundation.org, eric.dumazet@...il.com,
	greearb@...delatech.com
Subject: Re: [patch net-next-2.6 00/22] vlan cleanup round1

Sat, Jul 16, 2011 at 01:07:19AM CEST, jpirko@...hat.com wrote:
>Sat, Jul 16, 2011 at 12:15:42AM CEST, mirqus@...il.com wrote:
>>2011/7/15 Jiri Pirko <jpirko@...hat.com>:
>>> This patchset converts several drivers to new vlan model.
>>> Also kills several vlan helpers:
>>> vlan_hwaccel_receive_skb,
>>> lro_vlan_hwaccel_receive_frags,
>>> lro_vlan_hwaccel_receive_skb
>>
>>It looks like most drivers that implement rx_add/kill_vid also need
>>bitmap recording all enabled VLANs. I think this could be done in
>>networking core for those devices in a generic way (set/clear before
>>corresponding rx_add/kill_vid call). The bitmap should be dynamically
>>allocated when needed (either on device registration time, or adding
>>first VLAN).

Problem is that for example in bonding, slaves do not have their
netdev->vlgrp set, they are not "officially" used by vlan code.
So their must maintain list of vids themselves. I would leave this as
it is atm and see what we can do later on.

>
>Right, I'm going to think about it. I might repost this patchset after
>that, So Dave please do not apply right away, thanks.

I will probably repost some of patches if my ndo_vlan_[enable/disable]
patch will be applied.

>
>Jirka
>>
>>This might be out of scope for this cleanup, though.
>>
>>Looks good otherwise.
>>
>>Best Regards,
>>Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html