netdev - Re: problem with function vlan_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201107171615491568697@gmail.com>
Date:	Sun, 17 Jul 2011 16:15:51 +0800
From:	"jiangtao.jit" <jiangtao.jit@...il.com>
To:	"Francois Romieu" <romieu@...zoreil.com>
Cc:	"netdev" <netdev@...r.kernel.org>
Subject: Re: problem with function vlan_get_protocol()


Thanks a lot Francois
thank you for your explanation

--
jiangtao



发件人： Francois Romieu 
发送时间： 2011-07-17  15:49:00 
收件人： jiangtao.jit 
抄送： netdev 
主题： Re: problem with function vlan_get_protocol() 
 
jiangtao.jit <jiangtao.jit@...il.com> :
[...]
> do we need an else branch on pointer protop failed ?  through the else is unlikely 
> 
>  if (likely(protop))
>  protocol = *protop;
>     else
>  protocol = proto;
> 
> is it necessary ?
The else branch signals that skb_header_pointer uncloaked a really tiny
ethernet frame : the content of proto is not even initialized (stack
allocation), whence irrelevant. In such circumstances the default
initialization value of protocol (0) does not seem too bad.
-- 
Ueimor