netdev - Re: [RFC PATCH] net: vlan: 802.1ad S-VLAN support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110718.113731.1384541339327086734.davem@davemloft.net>
Date:	Mon, 18 Jul 2011 11:37:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	equinox@...c24.net
Cc:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [RFC PATCH] net: vlan: 802.1ad S-VLAN support

From: David Lamparter <equinox@...c24.net>
Date: Sun, 17 Jul 2011 22:55:05 +0200

>  - int vlan_pidx(u16 protocol)
>    do i do this with a table? that wastes a cacheline... as code it's
>    around 32 bytes on x86_64. it's not called for regular 802.1Q frames
>    from any hot paths btw, so maybe i shouldn't care?

Don't worry about something you haven't seen on profiling output yet,
unless it's something painfully obvious (f.e. using linked list of
thousands of entries for lookups)

FWIW, the counter argument for your concern is that the function
version takes up an I-cache line.

Anyways, like I said, I'd just leave it alone and get rid of all of
that #if 0 stuff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html