lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Jul 2011 11:45:24 +0200 From: Patrick McHardy <kaber@...sh.net> To: Eric Dumazet <eric.dumazet@...il.com> CC: Florian Westphal <fw@...len.de>, netfilter-devel@...r.kernel.org, Pablo Neira Ayuso <pablo@...filter.org>, netdev <netdev@...r.kernel.org>, Eric Leblond <eric@...it.org> Subject: Re: [PATCH next] netfilter: nfqueue: batch verdict support On 03.07.2011 12:24, Eric Dumazet wrote: > The real question hidden here is : "Should packet ids be monotonic" in > current implementation and all future ones ? > > Before we accept this patch, we should make sure packets id are > monotonic, and I am afraid its not the case right now. > > I suggest following patch then. > > [PATCH] netfilter: nfqueue: assert monotonic packet ids > > Packet identifier is currently setup in nfqnl_build_packet_message(), > using one atomic_inc_return(). > > Problem is that since several cpus might concurrently call > nfqnl_enqueue_packet() for the same queue, we can deliver packets to > consumer in non monotonic way (packet N+1 being delivered after packet > N) > > This patch moves the packet id setup from nfqnl_build_packet_message() > to nfqnl_enqueue_packet() to guarantee correct delivery order. > > This also removes one atomic operation. > > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com> > CC: Florian Westphal <fw@...len.de> > CC: Pablo Neira Ayuso <pablo@...filter.org> > CC: Eric Leblond <eric@...it.org> Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists