netdev - Re: [PATCH 1/3] stmmac: unify MAC and PHY configuration parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110719.115738.131562530013095617.davem@davemloft.net>
Date:	Tue, 19 Jul 2011 11:57:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, stuart.menefy@...com
Subject: Re: [PATCH 1/3] stmmac: unify MAC and PHY configuration parameters

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Tue, 19 Jul 2011 10:38:02 +0200

> Prior to this change, most PHY configuration parameters were passed
> into the STMMAC device as a separate PHY device. As well as being
> unusual, this made it difficult to make changes to the MAC/PHY
> relationship.
> 
> This patch moves all the PHY parameters into the MAC configuration
> structure, mainly as a separate structure. This allows us to completly
> ignore the MDIO bus attached to a stmmac if desired, and not create
> the PHY bus. It also allows the stmmac driver to use a different PHY
> from the one it is connected to, for example a fixed PHY or bit banging
> PHY.
> 
> Also derive the stmmac/PHY connection type (MII/RMII etc) from the
> mode can be passed into <platf>_configure_ethernet.
> STLinux kernel at git://git.stlinux.com/stm/linux-sh4-2.6.32.y.git
> provides several examples how to use this new infrastructure (that
> actually is easier to maintain and clearer).
> 
> Signed-off-by: Stuart Menefy <stuart.menefy@...com>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

I find these changes confusing, because I can't see where these
platform data objects are created that end up being used by
the stmmac driver.

I'm concerned about this because if you're changing these data
structures, you'll need to update also the code that creates
these platform data objects.

Finally, this patch needs to update Documentation/networking/stmmac.txt

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html