netdev - RE: [PATCH] pktgen: Clone skb to avoid corruption of skbs in ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D3F292ADF945FB49B35E96C94C2061B912AC4058@nsmail.netscout.com>
Date:	Wed, 20 Jul 2011 11:17:01 -0400
From:	"Loke, Chetan" <Chetan.Loke@...scout.com>
To:	"Eric Dumazet" <eric.dumazet@...il.com>,
	"Neil Horman" <nhorman@...driver.com>
Cc:	"Ben Greear" <greearb@...delatech.com>,
	"Jiri Pirko" <jpirko@...hat.com>, <netdev@...r.kernel.org>,
	"Alexey Dobriyan" <adobriyan@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: RE: [PATCH] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods


> So when I said "remove pktgen" from distro it was not a joke.
> Maybe its time to admit pktgen has to be removed from kernel sources.
> 

Please, let's not remove pktgen from kernel sources. We can add a CONFIG_PKTGEN as someone mentioned in the email thread.


> $ wc net/core/pktgen.c
>  3788 10881 92771 net/core/pktgen.c
> 
> Hmmm, 3788 lines, patched 180 times for a thing that only sends UDP
> frames...

It really doesn't matter what traffic it sends. As long as I can get some high speed throughput I am good.
There are quite a few use-cases where one doesn't really need to know the traffic profile.