netdev - Re: [patch net-next-2.6 35/47] e1000: do vlan cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110720190825.GC2688@minipsycho.redhat.com>
Date:	Wed, 20 Jul 2011 21:08:27 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	shemminger@...ux-foundation.org, eric.dumazet@...il.com,
	greearb@...delatech.com, mirqus@...il.com,
	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	peter.p.waskiewicz.jr@...el.com, bruce.w.allan@...el.com,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	gregory.v.rose@...el.com, alexander.h.duyck@...el.com,
	john.ronciak@...el.com, e1000-devel@...ts.sourceforge.net
Subject: Re: [patch net-next-2.6 35/47] e1000: do vlan cleanup

Wed, Jul 20, 2011 at 07:48:32PM CEST, jesse@...ira.com wrote:
>On Wed, Jul 20, 2011 at 7:54 AM, Jiri Pirko <jpirko@...hat.com> wrote:
>> @@ -4532,9 +4539,8 @@ static void e1000_vlan_rx_register(struct net_device *netdev,
>>
>>        if (!test_bit(__E1000_DOWN, &adapter->flags))
>>                e1000_irq_disable(adapter);
>> -       adapter->vlgrp = grp;
>>
>> -       if (grp) {
>> +       if (vlan_on) {
>>                /* enable VLAN tag insert/strip */
>>                ctrl = er32(CTRL);
>>                ctrl |= E1000_CTRL_VME;
>
>Same comment here as with the igb driver.

The driver behaviour remains intact here.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html