netdev - RE: [Pv-drivers] [PATCH net-next] vmxnet3: set netdev parant device before calling netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0975FDF228005340AA9C93B7681E5E8B13818C32F1@exch-mbx-112.vmware.com>
Date:	Wed, 20 Jul 2011 21:05:46 -0700
From:	Shreyas Bhatewara <sbhatewara@...are.com>
To:	Joe Perches <joe@...ches.com>, Scott Goldman <scottjg@...are.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"pv-drivers@...are.com" <pv-drivers@...are.com>
Subject: RE: [Pv-drivers] [PATCH net-next] vmxnet3: set netdev parant device
 before calling netdev_info

> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: Wednesday, July 20, 2011 8:49 PM
> To: Scott Goldman
> Cc: Shreyas Bhatewara; netdev@...r.kernel.org; pv-drivers@...are.com
> Subject: RE: [Pv-drivers] [PATCH net-next] vmxnet3: set netdev parant
> device before calling netdev_info
> 
> On Wed, 2011-07-20 at 20:06 -0700, Scott Goldman wrote:
> > > Parent device for netdev should be set before netdev_info() can be
> called
> > > otherwise there is a NULL pointer dereference and probe() fails.
> 
> I believe this is not true.
> I don't see any NULL pointer dereference here.
> functions and macros reordered top to bottom.
> 


Thanks for looking Joe.
This happened in 2.6.36. I saw the panic in 2.6.34 and assumed that it would be same
in the latest kernel.
It would not panic in 3.0 but it is good to have the parent device set early.