netdev - Re: [PATCH][TRIVIAL] net, netfilter: Remove redundant goto in ebt_ulog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1107211402210.7300@pobox.suse.cz>
Date:	Thu, 21 Jul 2011 14:02:43 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org, coreteam@...filter.org,
	netfilter@...r.kernel.org, netfilter-devel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Patrick McHardy <kaber@...sh.net>,
	Bart De Schuymer <bart.de.schuymer@...dora.be>
Subject: Re: [PATCH][TRIVIAL] net, netfilter: Remove redundant goto in
 ebt_ulog_packet

On Sun, 17 Jul 2011, Jesper Juhl wrote:

> In net/bridge/netfilter/ebt_ulog.c:ebt_ulog_packet() the 'goto unlock'
> before the 'alloc_failure' label is completely redundant. This patch
> removes it.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  net/bridge/netfilter/ebt_ulog.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/net/bridge/netfilter/ebt_ulog.c b/net/bridge/netfilter/ebt_ulog.c
> index 26377e9..bf2a333 100644
> --- a/net/bridge/netfilter/ebt_ulog.c
> +++ b/net/bridge/netfilter/ebt_ulog.c
> @@ -216,7 +216,6 @@ unlock:
>  nlmsg_failure:
>  	pr_debug("error during NLMSG_PUT. This should "
>  		 "not happen, please report to author.\n");
> -	goto unlock;
>  alloc_failure:
>  	goto unlock;
>  }
> -- 
> 1.7.6
> 
> 
> PS. Please CC me on replies since I'm not subscribed to all the lists 
> copied on this mail.

Doesn't seem to be present in linux-next as of today. I have picked it up.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html