netdev - Re: [patch net-next-2.6 18/47 V2] igbvf: do vlan cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110721162338.GH2107@minipsycho>
Date:	Thu, 21 Jul 2011 18:23:39 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	"Rose, Gregory V" <gregory.v.rose@...el.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"shemminger@...ux-foundation.org" <shemminger@...ux-foundation.org>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"greearb@...delatech.com" <greearb@...delatech.com>,
	"mirqus@...il.com" <mirqus@...il.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
	"Skidmore, Donald C" <donald.c.skidmore@...el.com>,
	"Duyck, Alexander H" <alexander.h.duyck@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"jesse@...ira.com" <jesse@...ira.com>
Subject: Re: [patch net-next-2.6 18/47 V2] igbvf: do vlan cleanup

Thu, Jul 21, 2011 at 05:57:08PM CEST, gregory.v.rose@...el.com wrote:
>> -----Original Message-----
>> From: Jiri Pirko [mailto:jpirko@...hat.com]
>> Sent: Thursday, July 21, 2011 6:23 AM
>> To: netdev@...r.kernel.org
>> Cc: davem@...emloft.net; shemminger@...ux-foundation.org;
>> eric.dumazet@...il.com; greearb@...delatech.com; mirqus@...il.com;
>> Kirsher, Jeffrey T; Brandeburg, Jesse; Waskiewicz Jr, Peter P; Allan,
>> Bruce W; Wyborny, Carolyn; Skidmore, Donald C; Rose, Gregory V; Duyck,
>> Alexander H; Ronciak, John; e1000-devel@...ts.sourceforge.net;
>> jesse@...ira.com
>> Subject: [patch net-next-2.6 18/47 V2] igbvf: do vlan cleanup
>> 
>> - unify vlan and nonvlan rx path
>> - kill adapter->vlgrp and igbvf_vlan_rx_register
>> 
>> Signed-off-by: Jiri Pirko <jpirko@...hat.com>
>> ---
>>  drivers/net/igbvf/igbvf.h  |    4 +-
>>  drivers/net/igbvf/netdev.c |   55 +++++++++++++++++++--------------------
>> ----
>>  2 files changed, 26 insertions(+), 33 deletions(-)
>> 
>> diff --git a/drivers/net/igbvf/igbvf.h b/drivers/net/igbvf/igbvf.h
>> index d5dad5d..fd4a7b7 100644
>> --- a/drivers/net/igbvf/igbvf.h
>> +++ b/drivers/net/igbvf/igbvf.h
>> @@ -34,7 +34,7 @@
>>  #include <linux/timer.h>
>>  #include <linux/io.h>
>>  #include <linux/netdevice.h>
>> -
>> +#include <linux/if_vlan.h>
>> 
>>  #include "vf.h"
>> 
>> @@ -173,7 +173,7 @@ struct igbvf_adapter {
>> 
>>  	const struct igbvf_info *ei;
>> 
>> -	struct vlan_group *vlgrp;
>> +	unsigned long active_vlans[BITS_TO_LONGS(VLAN_N_VID)];
>>  	u32 bd_number;
>>  	u32 rx_buffer_len;
>>  	u32 polling_interval;
>> diff --git a/drivers/net/igbvf/netdev.c b/drivers/net/igbvf/netdev.c
>> index 64b47bf..d924b09 100644
>> --- a/drivers/net/igbvf/netdev.c
>> +++ b/drivers/net/igbvf/netdev.c
>> @@ -100,12 +100,12 @@ static void igbvf_receive_skb(struct igbvf_adapter
>> *adapter,
>>                                struct sk_buff *skb,
>>                                u32 status, u16 vlan)
>>  {
>> -	if (adapter->vlgrp && (status & E1000_RXD_STAT_VP))
>> -		vlan_hwaccel_receive_skb(skb, adapter->vlgrp,
>> -		                         le16_to_cpu(vlan) &
>> -		                         E1000_RXD_SPC_VLAN_MASK);
>> -	else
>> -		netif_receive_skb(skb);
>> +	if (status & E1000_RXD_STAT_VP) {
>> +		u16 vid = le16_to_cpu(vlan) & E1000_RXD_SPC_VLAN_MASK;
>> +
>> +		__vlan_hwaccel_put_tag(skb, vid);
>> +	}
>> +	netif_receive_skb(skb);
>>  }
>> 
>>  static inline void igbvf_rx_checksum_adv(struct igbvf_adapter *adapter,
>> @@ -1167,22 +1167,29 @@ static int igbvf_poll(struct napi_struct *napi,
>> int budget)
>>   */
>>  static void igbvf_set_rlpml(struct igbvf_adapter *adapter)
>>  {
>> -	int max_frame_size = adapter->max_frame_size;
>> +	int max_frame_size;
>>  	struct e1000_hw *hw = &adapter->hw;
>> 
>> -	if (adapter->vlgrp)
>> -		max_frame_size += VLAN_TAG_SIZE;
>> -
>> +	max_frame_size = adapter->max_frame_size + VLAN_TAG_SIZE;
>>  	e1000_rlpml_set_vf(hw, max_frame_size);
>>  }
>> 
>> -static void igbvf_vlan_rx_add_vid(struct net_device *netdev, u16 vid)
>> +static bool __igbvf_vlan_rx_add_vid(struct igbvf_adapter *adapter, u16
>> vid)
>>  {
>> -	struct igbvf_adapter *adapter = netdev_priv(netdev);
>>  	struct e1000_hw *hw = &adapter->hw;
>> 
>>  	if (hw->mac.ops.set_vfta(hw, vid, true))
>>  		dev_err(&adapter->pdev->dev, "Failed to add vlan id %d\n",
>> vid);
>> +		return false;
>> +	return true;
>> +}
>
>I'm pretty sure you intended to put a curly brace after the if statement here.

Right, missed that. Thanks.

Rsposting also with removing igbvf_set_rlpml call from
igbvf_restore_vlan since it is called from igbvf_configure_rx

Thanks

Jirka
>
>Other than that it seems fine.
>
>- Greg
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html