lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Jul 2011 17:08:55 -0700 (PDT) From: David Miller <davem@...emloft.net> To: nhorman@...driver.com Cc: greearb@...delatech.com, eric.dumazet@...il.com, jpirko@...hat.com, netdev@...r.kernel.org, adobriyan@...il.com, robert.olsson@....uu.se Subject: Re: [PATCH] pktgen: Clone skb to avoid corruption of skbs in ndo_start_xmit methods From: Neil Horman <nhorman@...driver.com> Date: Thu, 21 Jul 2011 19:50:49 -0400 > I'm happy to go down this route Dave, and agree, its a more solid solution, but > I think the problem with it (which Ben may have been alluding to previously) is > that pktgen doesn't use dev_queue_xmit or dev_hard_start_xmit to send frames. Neil, that's THE WHOLE POINT, and HOW MY IDEA WORKS. Pktgen bypasses those functions, so it won't trigger the check and therefore won't trigger making a copy of the SKB, since copying isn't needed. Only layering devices will end up eventually calling into those two functions and trigger the "need to copy because this SKB is pktgen shared" check. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists