netdev - Re: [PATCH net-2.6] jme: Fix unmap error (Causing system freeze)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHXqBF+1aJ0O9WxrZTKfYMm57emysfPUnA-=M9DZN5kUGnhW8g@mail.gmail.com>
Date:	Fri, 22 Jul 2011 09:45:42 +0200
From:	Michał Mirosław <mirqus@...il.com>
To:	cooldavid@...ldavid.org
Cc:	David Miller <davem@...emloft.net>,
	linux-netdev <netdev@...r.kernel.org>,
	Aries Lee <arieslee@...cron.com>,
	Devinchiu <devinchiu@...cron.com>,
	Jason Lamb <jason@...bhome.org>,
	Marcus Becker <marcus.disi@...il.com>,
	Marc Schiffbauer <mschiff@...too.org>,
	Jason Long <jason@...gsoftware.com>, stable@...nel.org
Subject: Re: [PATCH net-2.6] jme: Fix unmap error (Causing system freeze)

2011/7/21  <cooldavid@...ldavid.org>:
> From: Guo-Fu Tseng <cooldavid@...ldavid.org>
>
> This patch add the missing dma_unmap().
> Which solved the critical issue of system freeze on heavy load.
>
> Michal Miroslaw's rejected patch:
> [PATCH v2 10/46] net: jme: convert to generic DMA API
> Pointed out the issue also, thank you Michal.
> But the fix was incorrect. It would unmap needed address
> when low memory.

My patch also fixed another issue - from correctness point of view,
you should not use virt_to_page+dma_map_page here, but dma_map_single.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html