netdev - Re: icmp_route_lookup returns wrong source address information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110722.071550.1280281689402202211.davem@davemloft.net>
Date:	Fri, 22 Jul 2011 07:15:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org
Subject: Re: icmp_route_lookup returns wrong source address information

From: Florian Westphal <fw@...len.de>
Date: Fri, 22 Jul 2011 16:15:31 +0200

> David Miller <davem@...emloft.net> wrote:
>> From: Florian Westphal <fw@...len.de>
>> Date: Wed, 20 Jul 2011 21:22:58 +0200
>> 
>> > Problem is that xfrm_decode_session_reverse() may rebuild fl4 from scratch.
>> > 
>> > In my setup, "goto relookup_failed" will be hit a bit later on, and fl4->saddr will
>> > be set to iph->daddr...
>> 
>> Indeed, we can't use this new fl4 until we commit to using 'rt2'.
>> 
>> Please give this patch a try:
>> 
>> --------------------
>> icmp: Fix regression in nexthop resolution during replies.
>> 
>> icmp_route_lookup() uses the wrong flow parameters if the reverse
>> session route lookup isn't used.
>> 
>> So do not commit to the re-decoded flow until we actually make a
>> final decision to use a real route saved in 'rt2'.
> 
> Thanks, traceroute shows the expected 1st hop again
> with your patch applied.

Thanks for testing!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html