netdev - RE: [PATCH net-next-2.6 2/2] be2net: use stats-sync to read/write 64-bit stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3367B80B08154D42A3B2BC708B5D41F63FFD9AC260@EXMAIL.ad.emulex.com>
Date:	Tue, 26 Jul 2011 22:34:36 -0700
From:	<Sathya.Perla@...lex.Com>
To:	<shemminger@...tta.com>
CC:	<netdev@...r.kernel.org>
Subject: RE: [PATCH net-next-2.6 2/2] be2net: use stats-sync to read/write
 64-bit stats

>-----Original Message-----
>From: Stephen Hemminger [mailto:shemminger@...tta.com]
>Sent: Tuesday, July 26, 2011 8:28 PM
>
>On Tue, 26 Jul 2011 10:40:15 +0530
>Sathya Perla <sathya.perla@...lex.com> wrote:
>
>> 64-bit stats in be2net are written/read as follows using the stats-sync
>> interface for safe access in 32-bit archs:
>>
>> 64-bit 		sync			writer			reader
>> stats
>> --------------------------------------------------------------------------
>----
>> tx_stats	tx_stats->sync		be_xmit			be_get_stats64,
>> 								ethtool
>> tx-compl	tx_stats->sync_compl	tx-compl-processing	ethtool
>> rx-stats	rx_stats->sync		rx-compl-processing	be_get_stats64,
>> 								ethtool,
>> 								eqd-update
>>
>> This patch is based on Stephen Hemminger's earlier patch on the same
>issue...
>>
>> Signed-off-by: Sathya Perla <sathya.perla@...lex.com>
>
>Is the tx complete stat even worth the effort? does it provide a useful
>metric?
>Since rx/tx bytes are already in regular stats, keeping them in ethtool
>stats
>is redundant.
>
>These are just minor nits, you can ignore this advice if you want.

Stephen, in the 1/2 patch (in this set) I did remove the aggregate rx/tx bytes & pkts
from ethtool to avoid duplication. I've retained the *per-ring* stats in
ethtool as they are not provided by be_get_stats64().

The per-ring tx-compl stat, has helped on occasion in field debugging.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html