netdev - Re: gro: Only reset frag0 when skb can be pulled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110727.061719.1278203020782685803.davem@davemloft.net>
Date:	Wed, 27 Jul 2011 06:17:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.hengli.com.au
Cc:	netdev@...r.kernel.org
Subject: Re: gro: Only reset frag0 when skb can be pulled

From: Herbert Xu <herbert@...dor.hengli.com.au>
Date: Wed, 27 Jul 2011 21:10:08 +0800

> gro: Only reset frag0 when skb can be pulled
> 
> Currently skb_gro_header_slow unconditionally resets frag0 and
> frag0_len.  However, when we can't pull on the skb this leaves
> the GRO fields in an inconsistent state.
> 
> This patch fixes this by only resetting those fields after the
> pskb_may_pull test.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks.

I'll queue this up for -stable too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html