lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Jul 2011 22:41:25 -0700 (PDT) From: David Miller <davem@...emloft.net> To: andy@...yhouse.net Cc: netdev@...r.kernel.org, vitas@...factor.kiev.ua, fubar@...ibm.com, tumeya@...hat.com Subject: Re: [PATCH net-next v3] bonding: fix string comparison errors From: Andy Gospodarek <andy@...yhouse.net> Date: Tue, 26 Jul 2011 17:12:27 -0400 > When a bond contains a device where one name is the subset of another > (eth1 and eth10, for example), one cannot properly set the primary > device or the currently active device. > > This was reported and based on work by Takuma Umeya. I also verified > the problem and tested that this fix resolves it. > > V2: A few did not like the the current code or my changes, so I > refactored bonding_store_primary and bonding_store_active_slave to be a > bit cleaner, dropped the use of strnicmp since we did not really need > the comparison to be case insensitive, and formatted the input string > from sysfs so a comparison to IFNAMSIZ could be used. > > I also discovered an error in bonding_store_active_slave that would > modify bond->primary_slave rather than bond->curr_active_slave before > forcing the bonding driver to choose a new active slave. > > V3: Actually sending the proper patch.... > > Signed-off-by: Andy Gospodarek <andy@...yhouse.net> > Reported-by: Takuma Umeya <tumeya@...hat.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists