netdev - Re: [net-next v2 03/71] amd: Move AMD (Lance) chipset drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXYoKkZrczdB6qPC1pfAGoTqgOiK2joY-38dewrVm5cRQ@mail.gmail.com>
Date:	Sun, 31 Jul 2011 10:14:34 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com,
	Peter Maydell <pmaydell@...ark.greenend.org.uk>,
	Roman Hodek <Roman.Hodek@...ormatik.uni-erlangen.de>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Donald Becker <becker@...ld.com>,
	Sam Creasey <sammy@...rs.qual.net>,
	Miguel de Icaza <miguel@...lecu.unam.mx>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	Don Fry <pcnet32@...ntier.com>,
	Russell King <linux@....linux.org.uk>,
	David Davies <davies@...iac.ultranet.com>,
	"M.Hipp" <hippm@...ormatik.uni-tuebingen.de>,
	Pete Popov <ppopov@...eddedalley.com>,
	David Hinds <dahinds@...rs.sourceforge.net>,
	"Roger C. Pao" <rpao@...net.org>
Subject: Re: [net-next v2 03/71] amd: Move AMD (Lance) chipset drivers

On Sun, Jul 31, 2011 at 05:26, Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
> --- /dev/null
> +++ b/drivers/net/ethernet/amd/Kconfig
> @@ -0,0 +1,188 @@
> +#
> +# AMD network device configuration
> +#
> +
> +config NET_VENDOR_AMD
> +       bool "AMD devices"
> +       depends on DIO || MACH_DECSTATION || MVME147 || ATARI || SUN3 || \
> +                  SUN3X || SBUS || PCI || ZORRO || (ISA && ISA_DMA_API) || \
> +                  (ARM && ARCH_EBSA110) || ISA || EISA || MCA || PCMCIA

Do you really need this big dependency? It will be true in almost all
cases anyway,
and the individual driver options are protected by other dependencies.
Just enabling this option doesn't make the kernel bigger.

> +       ---help---
> +         If you have a network (Ethernet) chipset belonging to this class,
> +         say Y.
> +
> +         Note that the answer to this question does not directly affect
> +         the kernel: saying N will just case the configurator to skip all
> +         the questions regarding AMD chipsets. If you say Y, you will be asked
> +         for your specific chipset/driver in the following questions.
> +
> +config A2065
> +       tristate "A2065 support"
> +       depends on NET_VENDOR_AMD && ZORRO

What about putting all driver sections inside "if NET_VENDOR_AMD" /
"endif", so the
individual driver configs don't need to depend on NET_VENDOR_AMD anymore?

The rest looks fine to me.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html