netdev - Re: [net-next v2 11/71] ni5010: Move the Racal-Interlan (Micom) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312140019.20837.125.camel@jtkirshe-mobl>
Date:	Sun, 31 Jul 2011 12:20:18 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Andreas Mohr <andi@...as.de>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	Jan-Pascal van Best <janpascal@...best.org>
Subject: Re: [net-next v2 11/71] ni5010: Move the Racal-Interlan (Micom)
 driver

On Sun, 2011-07-31 at 09:57 -0700, Andreas Mohr wrote:
> Hi,
> 
> On Sat, Jul 30, 2011 at 08:26:30PM -0700, Jeff Kirsher wrote:
> > Moves the Racal-Interlan driver into drivers/net/ethernet/racal/ and
> > make the necessary Kconfig and Makefile changes.
> 
> Acked-by: Andreas Mohr <andi@...as.de>
> 
> ---
> 
> Sorry, I had intended to reply to the original RFC,
> but due to vacation backlog that got swept under the rug.
> 
> Since it's a simple move it seems to be fine.
> 
> One minor nit, however: since ni5210 (as seen in some other patch)
> got moved to its respective NON-racal location (due to using a specific
> chipset),
> a short Kconfig addition explaining the whereabouts of ni5210
> (and perhaps some other OEM chipset Racal cards?) would be useful.

Sounds good, would you be up for sending my a patch against my tree and
I can fold it into my current patchset?  Or do you want to just send a
patch later on?  I know what your intention is, I am just not sure how
you would like it to show up in the Kconfig.

My git tree with this patch series applied is:
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-organize

> 
> Thank you for the probably long overdue cleanup of drivers/net/
> into something more specific and thus much more easy on the eye :)

Thanks, it is nice to hear.

> 
> Andreas Mohr



Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)