netdev - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110801151308.GA31256@elte.hu>
Date:	Mon, 1 Aug 2011 17:13:08 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Miller <davem@...emloft.net>
Cc:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT] Networking

* David Miller <davem@...emloft.net> wrote:

>       forcedeth: do vlan cleanup

Trying to bring latest -git into latest -tip today i managed to 
bisect back to a pretty bad networking breakage on one of my 
testboxes back to this commit - where i have discovered that it has 
been fixed freshly.

This bug cost me multiple days of debugging so here's a bit of a post 
mortem.

The bit that IMO wasnt very optimal was the timing of the merge path:

 -                  AuthorDate: Wed Jul 20 04:54:38 2011 +0000
 -                  CommitDate: Thu Jul 21 13:47:57 2011 -0700
 - tree Linus merge CommitDate: Fri Jul 22 14:43:13 2011 -0700
 -        first lkml bugreport: Sun Jul 24 16:10:59 2011 -0700
 -              fix CommitDate: Wed Jul 27 22:39:30 2011 -0700
 - fix  Linus merge CommitDate: Thu Jul 28 05:58:19 2011 -0700

So you can see that the commit was committed to net-next within 24 
hours of it being submitted, the (bad) breakage was not discovered 
until 4 days down the road.

I submit that *no one* with real forcedeth hardware actually tested 
this commit before it hit upstream. It has not touched linux-next 
before going to Linus and it took 8 days for the fix to get upstream.

If the latency of common driver bugfixes is on the order of 1 week 
then the golden rule is that commits must be tested for at least 1 
week as well. One day of testing was *way* too short.

Furthermore, the changelog of the fix:

 0891b0e08937: forcedeth: fix vlans

Doesn't contain any reference to the bisection work done by
walt <w41ter@...il.com> nor by any of the other bugreporters.

So this really sucked all around - could we please improve on it?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html