netdev - Re: [net-next v2 02/71] 3c*/acenic/typhoon: Move 3Com Ethernet drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312229757.1984.6.camel@jtkirshe-mobl>
Date:	Mon, 01 Aug 2011 13:15:56 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	Philip Blundell <philb@....org>,
	Steffen Klassert <klassert@...hematik.tu-chemnitz.de>,
	David Dillow <dave@...dillows.org>,
	Jes Sorensen <jes@...ined-monkey.org>,
	Donald Becker <becker@...ld.com>,
	Craig Southeren <craigs@...luki.apana.org.au>,
	David Hinds <dahinds@...rs.sourceforge.net>
Subject: Re: [net-next v2 02/71] 3c*/acenic/typhoon: Move 3Com Ethernet
 drivers

On Mon, 2011-08-01 at 02:03 -0700, Alan Cox wrote:
> On Sat, 30 Jul 2011 20:26:21 -0700
> Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
> 
> > Moves the 3Com drivers into drivers/net/ethernet/3com/ and the
> > necessary Kconfig and Makefile changes.
> 
> This still seems crazy
> 
> The 3c503 is not being moved (as its 8390 based)
> 
> But the 3c505/3c523/3c527/3c507 by that logic also shouldn't be moved
> as really they all belong with the rest of the Intel devices they are
> basically variants of (the 3c527 is weirder, in fact you can probably
> run CP/M 86 on it if you were mad enough)

I did as you asked, just not in this patch.  I should have cleaned up
this patch to reflect the changes I made in patch #4 and #10.

> 
> >  drivers/net/{pcmcia => ethernet/3com}/3c574_cs.c |    0
> >  drivers/net/{pcmcia => ethernet/3com}/3c589_cs.c |    0
> 
> These are currently sensibly where they belong - with the pcmcia
> adapters.
> 
> >  drivers/net/{ => ethernet/3com}/3c59x.c          |    0
> >  drivers/net/ethernet/3com/Kconfig                |  200
> > ++++++++++++++++++++++
> > drivers/net/ethernet/3com/Makefile               |   16 ++
> > drivers/net/{ => ethernet/3com}/acenic.c         |    0
> > drivers/net/{ => ethernet/3com}/acenic.h         |    0
> 
> And most Acenic devices are probably branded Netgear not 3COM and may
> also claim to be from Farallon, SGI, Alteon or DEC. Again not a 3Com
> originated part.
> 
> So I still think this patch is utter nonsense and just noise.
> 
> There isn't any sense in trying to line the network drivers up by
> whatever is written on the box that was thrown away years before. The
> reality is that most cards do not bear anything relevant to the chipset
> vendors name, even by the early 1990s. 
> 
> Architectually it makes more sense to keep tidy by bus type and by
> chipset, not by vendor name
> 
> NAK
> 
> And even if you wanted to make Kconfig simpler - you don't need to move
> files around.
> 
> Alan



Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)